commit a4a0bb0c431a4bee37df48d929a85ca02408ef18 Author: Garrett Malmquist Date: Tue Nov 10 10:38:46 2015 -0500 Fixing malformatted xml report names from junit runner. In https://rbcommons.com/s/twitter/r/3090/ I got the junit runner to anticipate getting Descriptions with class names and method names that were actually descriptions from frameworks like cucumber. This stopped the runner from failing out with an NPE and solved the internal use case I was checking against, but it turns out there's another problem I overlooked (uncovered by running it against another internal use-case). The TestSuite names were also used to generate the filenames of the xml reports. This does not work when the file name is some crazy Cucumber scenario description complete with special characters and who knows what. So this sanitizes the name used for generating the xml file. Testing Done: Extended existing integration test for cucumber to include Scenarios that would otherwise generate bad file names, and verified that this change fixes our internal problem. CI went green here: https://travis-ci.org/pantsbuild/pants/builds/90160989 CI went green here: https://travis-ci.org/gmalmquist/pants/builds/90160881 Bugs closed: 2529 Reviewed at https://rbcommons.com/s/twitter/r/3103/ .../tools/junit/impl/AntJunitXmlReportListener.java | 5 +++-- src/java/org/pantsbuild/tools/junit/impl/Util.java | 18 ++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-)